Atif Iqbal• 3,200
@atif-dev
Posted
Hi moon-sheep, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
- For proper centering the container(whole card) vertically and horizontally you can use code as:
body {
min-height: 100vh;
display: grid;
place-content: center;
}
- Remove
max-height: 90%;frommainselector for better display. - When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
- Include a README file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.
Hope you will find this Feedback Helpful.
Marked as helpful
1
