Order summary component (SASS)

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  nice work! I'd suggest changing height: 100vh to min-height: 100vh on the body, it is never a good idea to restrict text containing elements, sections etc. It might result in data loss and overflows, as it looks like the case for me when i view your solution on a notebook. Also adding some padding to body might prevent the card touching the (e.g. top) edges of the screen

  Hope you find this feedback helpful!

  Marked as helpful

  0

  ---

  

  Abdulrahman Muhammad•200

  @0abdulrahmanPosted over 1 year ago

  @visualdenniss I didn't consider checking the design on any screen other than the required mobile (375px width) and desktop (1440px width) sizes, I didn't care making it fully responsive tbh. However, the min-height: 100vh is a great idea, thank you!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  This comment was deleted over 1 year ago

  0

  ---

  

  Abdulrahman Muhammad•200

  @0abdulrahmanPosted over 1 year ago

  @0xAbdulKhalid Oh I simply did not see it, I thought they wanted a solid color. Thanks for informing me.

  0