Order Summary Component - sanbonilla.com

Community feedback

• 

  Alan Santos•50

  @alan-ssantosPosted about 3 years ago

  Hey @san-bonilla, great work on this challenge.

  I have some suggestions that can help you to fix some issues.

  • The <div class="card-main-container"> element should be <main class="card-main-container">, this will fix the a11y issue.
  • Change the <h2 class='text-title'> to <h1 class='text-title'>, because it's a best practice a page have a h1 title.
  • For the music icon, add aria-hidden="true” and remove the text of alt attribute alt="", because it's for decoration only.
  • <div class="plan-title">Annual Plan</div> and <div class="plan-price">$59.99/year</div> should be <p> element.
  • Lastly, you can change the background-size: cover to background-size: contain and the background-repeat: no-repeat to background-repeat: repeat-x this will make the background image looks better in different screen sizes.

  I hope this was helpful and keep doing the challenges. 😉😊

  0