Design comparison
SolutionDesign
Solution retrospective
I would appreciate it if someone could explain how I should place the hero image. Thank you !
Community feedback
- @darryncodesPosted almost 3 years ago
Hi Judith,
You've done a great job on this one, all the elements are there - i think with a few tweaks it could be a perfect match!
- you might want to add the hover effects to the buttons & links
- i'd update the background to
background-size: 100% auto;
so that the image doesn't get cut short on really wide screens - adding your padding to
.container
is creating a border around the image which is meant to be edge to edge. Perhaps add anotherdiv
to add padding to, or add it to the other elements in the card (you might needoverflow: hidden;
to ensure the border-radius is visible on the image) - you could include more descriptive html elements and [a
h1
] (https://www.w3.org/WAI/tutorials/page-structure/headings/) to clear your accessibility report
But overall really great work, keep up the momentum!
Marked as helpful1 - @juliettesimonotPosted almost 3 years ago
Hey Judith :) I can't have access to your code, but did you try to put the hero image in background ? In your CSS code? Also, maybe you could try to tune your window width bigger, so the text have more space, and appears better in the window:)
Have a nice day :)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord