Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Dipendu , congratulations for your new solution!
You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code to improve the html markup/semantic:
1.Replace the
div
with<main>
(every page should have a main landmark and also a main h1 heading) so replace the h3 to with<h1>
and follow the sequence if you add another heading as h1, h2, h3…2.Add
background-size: contain
to have the proper background sizing and centered with the card:body { font-family: 'Red Hat Display', sans-serif; min-height: 100vh; background-image: url(./images/pattern-background-desktop.svg); background-repeat: no-repeat; background-size: contain; background-color: hsl(225, 100%, 94%); position: relative; font-size: 16px; }
👾My rating for this solution: ⭐⭐⭐⭐
✌️ I hope this helps you and happy coding!
Marked as helpful0@Dipendu7718Posted about 2 years ago@correlucas Thanks for your help and suggestion. I try my best.
0@correlucasPosted about 2 years ago@Dipendu7718 you're welcome Dipendu, keep it up!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord