Design comparison
SolutionDesign
Solution retrospective
All feedbacks are welcome. Thank you
Community feedback
- @amalkarimPosted almost 2 years ago
Hi Mubaraq 👋
Congratulations for completing the challenge!
It's a nice solution. However, there are still room for improvements.
- To remove most warnings in Accessibility report, you need to wrap
<section class="order">
inside a<main></main>
block. - Do not use
<h4>
heading tag in<h4>Annual Plan</h4>
, instead use regular<p>
to be more semantic. Just add styles or use<b></b>
tag if you want it to be bold. - In mobile view, it looks like the content width is more than the
body
's width. It makes some part of the page have white background as opposed to the actual background-colorhsl(225, 100%, 94%)
. To solve this, add a media query like below:
@media screen and (max-width: 500px) { .icon img { width: 100%; height: auto; } .order-icon { width: 100%; } }
Hope this helps. Happy coding!
0 - To remove most warnings in Accessibility report, you need to wrap
- @suhaybjirdePosted almost 2 years ago
well done only add this font to your css file
@import url('https://fonts.googleapis.com/css2?family=Red+Hat+Display:wght@500;600;900&display=swap');
add this to your body selector
body { font-family: 'Red Hat Display', sans-serif; }
congrats by the way👏
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord