Design comparison
Solution retrospective
Really excited about frontend, being a backend engineer this is really fairly new for me. Would appreciate any feedback about the code.
Community feedback
- @SbZhechevPosted about 3 years ago
Hello there,
Great job! It looks design perfect! However, I see you are using mainly px. They are good and easy to use while starting but try and explore more responsive friendly units like em and rem for spacing. This way the spacing will be more consistent and scalable with the font of the text. This way you can scale the font size and have the spacing automatically update as well.
Another thing for responsive friendly code is to avoid setting fixed width and height (for example width: 320px;). Try using % or padding(especially for height) for them. I can`t get much more in depth with responsiveness but remember that html is responsive by default and we should try not to break it with our css.
Lastly, I saw you are using mainly divs in the html. Explore semantic html and use some of the new html5 tags(main, header, section, article, etc.). Semantic html helps with SEO optimization.
Keep up the good work and don`t be discouraged by the big world of front end!
Marked as helpful1 - @georgeokezPosted about 3 years ago
Thanks for the feedback, I'll keep all of what you've said in mind when starting out new projects.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord