Order summary component

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @msbarghini!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h5>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  Mia Sarah Barghini•30

  @msbarghiniPosted 10 months ago

  @danielmrz-dev

  Thanks for the feedback, I didn't know about heading semantics that's really interesting!

  Also, you're right, I was supposed to use "main" instead of DIV and completely forgot, thanks for pointing that out! I'll make sure to do that with the next challenge :)

  1
• 

  Leanghok•170

  @leanghok120Posted 10 months ago

  I do have some feedbacks for you, my first one is to scale the website up a bit, maybe make it a little bit bigger for 100% because I think you developed this for 150% (zoom). My second feedback is that you don't need to have a media query for this project at all, I did it with no media query and that is usually the best practice, if you could do it without media query then you should. And to center a div, you just have to:

  .container {
     display: flex;
     justify-content: center; /* align the div center horizontally */
     align-items: center; /* align the div center vertically */
  }
  

  Marked as helpful

  0

  ---

  

  Mia Sarah Barghini•30

  @msbarghiniPosted 10 months ago

  @leanghok120

  Great to know about the media queries, I always get stuck on that.

  And thanks for the centering DIV code :)

  Much appreciated!

  0