Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component

@codepalacios

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback to help me make the best practices would be greatly appreciated.

Community feedback

Ferβ€’ 3,970

@fernandolapaz

Posted

Hi πŸ‘‹, perhaps some of this may interest you:

HTML 🧱, ACCESSIBILITY βš–:

  • The images in this challenge are decorative images and therefore need an empty alt attribute to be ignored by a screen reader.

CSS 🎨:

  • It is better to use min-height: 100vh; for the body, as using height might cause the page to be cut off in viewports with small height (such as mobile landscape orientation).
  • Length units such as pixels may not be the best alternative because absolute units don’t scale. Relative units like rem or em are a better option for scalable layouts (the page will adjust to the user's browser settings) and maintenance (to make changes without having to adjust every pixel value).
  • Also, I wonder why you chose to create several style sheets... the common thing is to do it all in one.

Please let me know if you want more info on any of these topics or disagree with something. I hope it’s useful πŸ™‚

Regards,

Marked as helpful

1

@codepalacios

Posted

Hi @fernandolapaz, thanks for your comments on HTML and CSS. I will practice them soon to optimize the development of the projects.

Use multiple style sheets to optimize page loading, eg: on mobile, it will only download the mobile CSS component and not the others.

Greetings. :)

0
Ferβ€’ 3,970

@fernandolapaz

Posted

@codepalacios

Oh, that's very good.

And I'm glad if any of my suggestions helped you :)

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord