Order summary component

Community feedback

• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋, perhaps some of this may interest you:

  HTML 🧱, ACCESSIBILITY ⚖:

  • The images in this challenge are decorative images and therefore need an empty alt attribute to be ignored by a screen reader.

  CSS 🎨:

  • It is better to use min-height: 100vh; for the body, as using height might cause the page to be cut off in viewports with small height (such as mobile landscape orientation).

  • Length units such as pixels may not be the best alternative because absolute units don’t scale. Relative units like rem or em are a better option for scalable layouts (the page will adjust to the user's browser settings) and maintenance (to make changes without having to adjust every pixel value).

  • Also, I wonder why you chose to create several style sheets... the common thing is to do it all in one.

  Please let me know if you want more info on any of these topics or disagree with something. I hope it’s useful 🙂

  Regards,

  Marked as helpful

  1

  ---

  

  Christian Palacios•340

  @codepalaciosPosted over 1 year ago

  Hi @fernandolapaz, thanks for your comments on HTML and CSS. I will practice them soon to optimize the development of the projects.

  Use multiple style sheets to optimize page loading, eg: on mobile, it will only download the mobile CSS component and not the others.

  Greetings. :)

  0

  

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  @codepalacios

  Oh, that's very good.

  And I'm glad if any of my suggestions helped you :)

  Marked as helpful

  1