Design comparison
SolutionDesign
Community feedback
- @denieldenPosted almost 2 years ago
Hello Aima, You have done a good work! 😁
Some little tips to improve your code:
- use
article
tag to wrap the card and improve the Accessibility but not as a page container - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - remove all
margin
fromcard
class because with flex they are superfluous - use
min-height: 100vh
to article tag instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
0 - use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord