Design comparison
SolutionDesign
Community feedback
- @Thewatcher13Posted over 1 year ago
There should be a css reset in your css, look at Andy Bell his site for a good and modern one.
Your font-size should never be in PX but in rem for accessibility reasons. https://fedmentor.dev/posts/font-size-px/
Not a fault but, it's a good practise to use no units on line-height you can calculate that with line-height in px / font-size in px=line height without unit
A good tip, use variables for colors, variables are easy to maintenance and readibility/usability for writing the code
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord