Design comparison
Solution retrospective
Hello, this is my first challenge, and i'm learning css and html, so any constructive criticism is welcome, p.s. sorry for my english, i'm brazilian and i'm still learning english so i'm using google translator
Community feedback
- @Da-vi-dePosted about 3 years ago
Hi Caio, it's a nice result as first challenge, well done!
-
Good use of semantic HTML except at the beginning after
body
tag, the container shouldn't besection
butmain
instead.section
is not semantic and it's not the right region landmark for containing big code blocks. -
On mobile there's a horizontal scrollbar, you can get rid of it by adding
overflow: hidden
to yourbody
in CSS.
Keep coding :-)
Marked as helpful1@CaioRomanPosted about 3 years ago@Da-vi-de hi Davide, thanks for the help, i didn't know the main tag, so it helped a lot, and i don't know css responsive so i didn't do anything for mobile.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord