Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component Main

@jonathanleandro

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hello Jonathan, You have done a good work! 😁

Some little tips to improve your code:

  • To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the <div class="bg_image"></div>
  • use the button tag for the button card
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

Hope this help 😉 and Happy coding!

Marked as helpful

0
Lucas 👾 104,420

@correlucas

Posted

👾Oi Jonathan tudo bem? Parabéns pelo desafio!

Acabei de ver sua solução e tenho umas dicas pra melhorar seu código/design:

Adicione background-repeat: no-repeat pra fazr o background ficar como uma imagem só

html, body {
    min-height: 100vh;
    font-family: var(--RedHatDisplay);
    font-size: 16px;
    background-color: var(--Pale-blue);
    background-image: url(../images/pattern-background-desktop.svg);
    display: flex;
    flex-wrap: nowrap;
    align-items: center;
    background-repeat: no-repeat;
    justify-content: center;
    position: relative;
}

👋 Espero que essas dicas te ajudem e que você continue no foco!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord