Order Summary Component Main

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Jonathan, You have done a good work! 😁

  Some little tips to improve your code:

  • To fix the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the <div class="bg_image"></div>
  • use the button tag for the button card
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Oi Jonathan tudo bem? Parabéns pelo desafio!

  Acabei de ver sua solução e tenho umas dicas pra melhorar seu código/design:

  Adicione background-repeat: no-repeat pra fazr o background ficar como uma imagem só

  html, body {
      min-height: 100vh;
      font-family: var(--RedHatDisplay);
      font-size: 16px;
      background-color: var(--Pale-blue);
      background-image: url(../images/pattern-background-desktop.svg);
      display: flex;
      flex-wrap: nowrap;
      align-items: center;
      background-repeat: no-repeat;
      justify-content: center;
      position: relative;
  }
  

  👋 Espero que essas dicas te ajudem e que você continue no foco!

  Marked as helpful

  0