@denielden
Posted
Hello Gabriel, You have done a good work! 😁
Some little tips to improve your code:
- To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
- add
main
tag and wrap the card for improve the Accessibility - remove all
margin
from.app
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@AdrianoEscarabote
Posted
@denielden With contain
the background would keep cutting
@denielden
Posted
@AdrianoEscarabote You are right! I was wrong to write. With cover
it covers the entire screen.
Thanks for the correction Adriano 😁
Thank you very much @denielden for your help and advice!
@denielden
Posted
@gabrielCarrenio You are welcome and keep it up :)