Design comparison
SolutionDesign
Solution retrospective
- What did you find difficult while building the project?
- Which areas of your code are you unsure of?
- Do you have any questions about best practices?
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of
semantic
markup, which causes lacking of landmark for a webpage
- So fix it by replacing the
<section class="main">
element with the semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @0xabdulPosted over 1 year ago
Hello there well congrats on successfully completed the Order summary component 🤩
- A Little bit recommendation for improve your code
- In Html 🏷️ :
- The Main landmark
- th html page should be contained one main landmark so fix them
- to clear the Accessibility reports using semantic elements or non semantic elements
- for easy way to clear the all Accessibility reports using non - semantic elements Ex :
<div> , <span>
- let's try
- Ex :
<body> <div class="container" role="main"> //Html code here 🏷️ </div> </body>
- OR
- using semantic elements Ex :
<aside> <section> <main> <nav> <header> < footer>
- Ex :
<body> <header>company logo header name...</header> <main> the main content here</main> <footer>@Copy right Here</footer> </body> </html>
- I Hope you find the solution and it's useful for you 😀
- Happy Coding
ABNmmd
🤩
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord