order-summary-component-main

Community feedback

• 

  Martin Liesche•570

  @marliedevPosted 22 days ago

  Overall a clean and well done solution!

  My personal preference would be for the map to have a subtle shadow and for the primary button's shadow to be significantly reduced or even eliminated.

  What could be improved...maybe some tips, but as always it depends on the personal style and taste of developing when using standards like BEM and SMACSS.

  As the challenge title says: its a component. If you use the BEM Methodology, I personally prefer when naming the classes of the individual parts of a component that you can clearly see that they belong to the component

  e. g. don't use "main" or "container" for a component; instead name it "order-summary"!

  Thought ahead the different parts should be named "order-summary__image", "order-summary__content", "order-summary__button--primary" ....

  This way it's clear when scanning the code what belongs to what.

  Marked as helpful

  0

  ---

  

  P

  Davy•290

  @DavyZanePosted 22 days ago

  Hello Martin! Many thanks for your feedback.

  Actually I am not aware of the different possibilities to manage shadows and I don't use to spend time on it. I will update this challenge and apply your advice to see how this will improve the looking. I confess my shadow is ugly, I have done it at the very end of the challenge, with my head full. You let me opened my eyes on it ^^.

  I have been using BEM for a short time and without really knowing this standards completely. SMACSS is unknown to me, I will have a look on it as well. But I think I'm going to go step by step on these approaches, and you just made me do a quite big step :)

  I will have all these in mind for future challenges. Thanks!

  0