Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component Main

@NourElDinEmad

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Do you have any questions about best practices?

Community feedback

@dimar-hanung

Posted

Hello.. 👋, Congratulations on completing the challenge 🎉 .

I have some interest and feedback with your code

That i like:

  1. html is pretty good, not too nested with combination of semantic HTML👍
  2. class naming is also good, represents its use for what 👌

My Feedback:

  • The shadow is too bold
  • You can remove or make it have some color in bottom footer, so it looks mixed
  • You can seperate file by folder to be more structured, for example:
public/
├─ images/
│  ├─ illustration-hero.png
│  ├─ pattern-background-mobile.svg, etc..
├─ styles/
│  ├─ main.css
├─ favicon.png
index.html

anyways overall is good, nice solution, hope it useful 🙌

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord