dimar hanung• 560
@dimar-hanung
Posted
Hello.. 👋, Congratulations on completing the challenge 🎉 .
I have some interest and feedback with your code
That i like:
- html is pretty good, not too nested with combination of semantic HTML👍
- class naming is also good, represents its use for what 👌
My Feedback:
- The shadow is too bold
- You can remove or make it have some color in bottom footer, so it looks mixed
- You can seperate file by folder to be more structured, for example:
public/
├─ images/
│ ├─ illustration-hero.png
│ ├─ pattern-background-mobile.svg, etc..
├─ styles/
│ ├─ main.css
├─ favicon.png
index.html
anyways overall is good, nice solution, hope it useful 🙌
0