Design comparison
SolutionDesign
Solution retrospective
What did you find difficult while building the project? Which areas of your code are you unsure of?
- I find the back ground image a little hard, and I'm not even sure if I coded it correctly. I would love to hear some feedback and how to improve.
Community feedback
- @fernandolapazPosted over 1 year ago
Hi π, in case you want to take a look:
HTML π§±:
- It is good not to skip heading levels. If you are going to use more than one heading, start with
<h1>
, then<h2>
, and so on.
CSS π¨:
- If you want the card to be centered you should add
min-height: 100vh
to the body.
- Length units such as pixels may not be the best alternative because absolute units donβt scale. Relative units like rem or em are a better option for scalable layouts (the page will adjust to the user's browser settings) and maintenance (to make changes without having to adjust every pixel value).
I hope itβs useful π
Regards,
Marked as helpful2 - It is good not to skip heading levels. If you are going to use more than one heading, start with
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE πΈ:
- Looks like the background svg has not been properly set yet, So let me share my css snippet which helps you to easily apply the
background color
with thebackground svg
they provided to place perfectly as same as design.
- Add the following style rule to your css, and then experience the changes
body { background: url(./images/pattern-background-desktop.svg) no-repeat, #E1E9Ff; background-size: contain; }
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
1 - @ReactiveX22Posted over 1 year ago
Hi, I used a background-color in the body to achieve a similar or better result.
body { background-image: url(./images/pattern-background-desktop.svg); background-repeat: no-repeat; background-size: contain; background-color: var(--Pale-blue); π font-family: "Red Hat Display", sans-serif; font-size: 16px; }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord