Aman Singh Bhogal• 1,010
@asbhogal
Posted
Hi Isadora, great job! The design matches the mockup well. Just a couple of things I've noticed:
- Firstly, you should ideally have your background image in a
<picture>
element in your HTML with thesrc
paths to the mobile and desktop versions which change depending on the viewport width. I've added a link here from MDN about how to do this Link - Also, your
container
element could be placed in amax-width
of300px
for eg., with awidth: 100%
which means it only takes up that size, and anything below that will ensure it occupies the full width. This improves the responsiveness whilst ensuring there's adequate spacing between the container and the browser window. (At the moment its touching the sides of them.)
Hope this helps!
Marked as helpful
1
moonrose93• 370
@moonrose93
Posted
@asbhogal you are the best 👌
1
Aman Singh Bhogal• 1,010
@asbhogal
Posted
@moonrose93 appreciate it, thank you :) glad to help
0