Design comparison
Solution retrospective
Just finished the code today. I would like to receive every suggestion to improve my coding skill. Thank you.
Community feedback
- @jmnyaregaPosted over 3 years ago
Nice one on the challenge, I have a few observations
-
There is a small gap between the image & the bottom border of its container, you can fix that by add
display: block
to the image. -
buttons and links do not inherit fonts & colors by default. I think that's why the styles aren't applying to the buttons at bottom of the card.
-
Since buttons are focusable by default, you don't need to have links inside buttons, something like
<button> Proceed to Payment </button>
will be just fine. This will also reduce the styling nightmare 🙂 -
Prefer using relatives units.
Happy coding 🙂
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord