@Islandstone89
Posted
Hey, you have done a really good job here! What I like:
-
Including the
<main>
and<footer>
landmarks. -
Proper CSS Reset at the beginning of the stylesheet.
-
Good use of Custom Properties.
Here are a few things to take note of:
HTML:
-
The image is decorative, so its alt text should be empty:
alt=""
. -
Personally I see "Proceed to payment" as a link, as it would navigate to the next page.
-
Text in
.attribution
must be wrapped in a<p>
.
CSS:
.attribution
has font size inpx
, which is bad for accessibility. Change it intorem
.
@DeveloperChrisP
Posted
@Islandstone89 Thank you for those positives & the constructive feedback - That all makes sense. I will make those adjustments.
Annoyingly I realized I'd forgotten to refactor the 'desktop' sizes after I'd uploaded, so will amend that too. Thanks again.