Order Summary Component

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello 👋Vanessa Ayer, congratulations on completing this challenge 🎉.

  I have some suggestions you might find interesting.

  1 I noticed <h2> as the first heading in your code you should replace it with <h1>. And then replace <h3> with <h2>

  Here's a quick guide on how to use them:

  The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. You can then style them in you css.

  Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document

  2 You used max-width: 450px; On the .card This is okay but in case a screen is less than 450px wide then the card overflows the view port. You can make it more responsive by using max-width:min(90%,450px) This means it is 450px but on smaller screens it only covers 90% of the width.

  3 I noticed font-size: 16px; in your code. You should never use pixels when setting font related properties. Setting font sizes in pixels causes accessibility problems with people who adjusted their default font sizes on their computers.

  The best units for setting font size are relative units such as rem and em which can adjust with the user preferences. Checkout this article why font size should never be in pixels

  I hope this helps 🙃

  Otherwise your solution is neat👍

  Happy coding ✌️

  Marked as helpful

  1

  ---

  

  P

  Vanessa Ayer•90

  @vanessa-ayerPosted 10 months ago

  @rayaatta thank you soooo SO much! Your feedback is a game changer and I appreciate your help! I'm digging into your feedback now - Those updates will make all the difference and I will use this knowledge for future projects! 😀💡

  Thanks again!

  0

  

  raya•2,870

  @rayaattaPosted 10 months ago

  Happy to help@vanessa-ayer

  1