Skip to content
Submitted about 2 years ago

Order summary component

osama•270
@osamanazakat
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any suggestions on how I can improve are welcome!

Community feedback

  • David•8,000
    @DavidMorgadePosted about 2 years ago

    Hello Osama, congrats on finishing the challenge! the card looks pretty good IMO, I would add some things to it, if you don't mind I would like to give you some advices

    • First of all, I saw that you were trying to center it using flexbox nice job! but you need to set the body's height to wrapp all of the browser screen, you can do this by setting your <body> min-height: 100vh, with this the body will wrap the fully screen and your card will be centered.

    • Your background is covering the whole screen until it reach some point that in larger screens it gets cutoff, try setting background-size: contain for desktop sizes so it gets container in the background and fully displayed.

    • Regarding the html, remember that every document should have one <h1> to improve the accesibility and rank better on search engines, just use your 'Order Summary' as an <h1> to pass this validation and you are good to go!

    Hope my feedback helps you, if you have any questions, don't hesitate to ask, great job with the solution

    Marked as helpful
    1
    osama•270
    @osamanazakatPosted about 2 years ago

    @DavidMorgade Thanks Bro 👍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord