Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello again Radek , congratulations for your new solution!
You've a perfect container and card here, the only thing you need to fix is the background to display the wave properly, here's my tips:
To improve the background you need to use
background-repeat: no-repeat;
to make the wave svg to repeat andbackground-size: contain;
to display it full width and correct color for the background thats not white is blueishbackground-color: #eaeaff;
Here's your code with changes applied:
body { background-image: url(./images/pattern-background-desktop.svg); padding: 50px 20px; font-family: var(--ff-primary); background-repeat: no-repeat; background-size: contain; background-color: #eaeaff; }
👋 I hope this helps you and happy coding!
Marked as helpful1@RadexmanPosted about 2 years ago@correlucas Hey thanks for checking my code and your tips! I'm fairly new to this platform and I'm curious how you write those nice looking code snippets in your feedbacks.
0 - @mohamedKhaled89Posted about 2 years ago
Hey Radek, congratulations on completing the challenge! You did a great job
I think you need to change some things in your code:
- body background-color: var(--clr-primary-700);
- make your background-size: contain;
- and background-repeat: no-repeat;
- I think you must make a container for content for better positioning
Marked as helpful1@RadexmanPosted about 2 years ago@mohamedKhaled89 Thanks for taking the time to review my code, I will improve it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord