Design comparison
SolutionDesign
Solution retrospective
Struggled a lot doing this one, trying to improve, feedback is welcome.
Community feedback
- @RikvanderSarPosted about 3 years ago
Hi,
Just wanted to give you some quick feedback. Great job on this challenge! Just a couple of things you might want to take a look at:
- The div that you called 'container' might be more appropriate to call 'card'.
- You don't really need flexbox on you container div. It is now used to center the content of your card in the middle. But you could also try to fix the challenge without flexbox on the container. If you do that, don't forget to put 'display: inline-block' on you're <a> tags end center them with margin: 0 auto.
- On your 'plano-container' you use a margin-left: -40. It looks like this pulls the div out of the middle because you've already used flexbox, space-around on the parent.
- I think it's a good idea to use English in all you're documents and naming so that it is easier for other people to understand it.
Great job! Hope this feedback helps you a little bit further.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord