Design comparison
Solution retrospective
Please give your feedback on this. :)
Community feedback
- @anoshaahmedPosted almost 3 years ago
For .bg_img add the contain property: background: url("../images/pattern-background-mobile.svg") no-repeat top / contain
Marked as helpful0@Harshi786Posted almost 3 years ago@anoshaahmed is the code correct now? Thanks for the help :D
1 - @RioCantrePosted almost 3 years ago
Hi there! Great job on this one! You did well on implementing the design and looking at your code it's pretty decent. To make it more appealing, just in case you wanted to tweak tiny details I would like to suggest the following:
- Clean the whitespaces in your code.
- Add padding or margin to the
.attribution
to have space in between - Wrap the
.attribution
tofooter
tag because it best practice to use specific tag for its purpose and put it bellow themain
close tag.
Once again, keep up the good work !
Marked as helpful0@Harshi786Posted almost 3 years ago@RioCantre Hey! As this was my first challenge, So I was very excited for the feedback. Thank you for the one.
0 - @GamuchiraiSPosted almost 3 years ago
This looks amazing!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord