Design comparison
Solution retrospective
I'm not sure if the jump you can see when going from the desktop breakpoint to mobile is okay... Am I doing something wrong here? Is there a way to handle this change more elegantly or is it fine and expected to behave that way?
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Jennifer Chavarria, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
- Add a
background-repeat: repeat-x;
, the image will repeat on the horizontal axis, preventing it from breaking. - Add a
background-size: 100% 50vmin;
, the50vmin
will set its height as the page target, and100%
will make it stretch on the horizontal axis.
Feel free to choose one of the two!
avoid using
px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to remThe rest is great!
I hope it helps... 👍
1@jenn-chav13Posted almost 2 years ago@AdrianoEscarabote Thank you! I had no clue about the px for font sizes :) I will keep that in mind from now on.
0 - Add a
- @suhaybjirdePosted almost 2 years ago
well done but it seem it's over-flowing a little bit add your body selector
body { over-flow: hidden;}
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord