Design comparison
Solution retrospective
If you have any suggestions Always welcome :)
Community feedback
- @ojaswishivamPosted about 2 years ago
Hello @rdghostmann, first of all, congrats on completing this challenge.
Here are some suggestions to improve your code:
-
In this challenge, there is a shadow to download button.
Here is the preview(look closely at the download button): https://ojaswishivam.github.io/order-summary/#
you can do so by using Drop Shadow, Here is the code:
filter: drop-shadow(0 12px 7px rgba(7, 23, 255, .245));
Helpful Link: Drop-Shadow
Happy Coding!! 👻🎃
Marked as helpful1 -
- @AdrianoEscarabotePosted about 2 years ago
Hi Varun Pandey, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
-
Add a
background-repeat: repeat-x;
, the image will repeat on the horizontal axis, preventing it from breaking. -
Add a
background-size: 100% 50vmin;
, the50vmin
will set its height as the page target, and100%
will make it stretch on the horizontal axis.
Feel free to choose one of the two!
The rest is great!
I hope it helps... 👍
Marked as helpful1@varunUk09Posted about 2 years ago@AdrianoEscarabote bro thanku so much for helping me and giving me clear understanding of rem. And i will keep in mind all your points
again thanks dude!! (lots of love from India)
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord