Design comparison
SolutionDesign
Solution retrospective
Your feedback matters!
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there ๐. Good job on completing the challenge !
I have only one suggestion about your code that might interest you.
- Improve the background image responsiveness by adding
background-size: contain
to adapt to various devices, especially noticeable when enlarging the screen using DevTools.
- Consider using a button instead of an anchor tag for the "change" element, as buttons are designed for actions like altering the order's plan. Anchors are typically used for linking In this instance, the action involves altering the order's plan, making a button a more fitting choice.
I hope you find it useful! ๐
Happy coding!
2@AhlamAb22Posted about 1 year ago@MelvinAguilar This is helpful, I will work on that. Thank you!
1 - Improve the background image responsiveness by adding
- @Zy8712Posted about 1 year ago
Your site looks great! Only things I'd suggest you to do is:
- shift or remove the css for the attribution so that you don't have css spread out across multiple files (in larger projects it may be justifiable to split the css)
- use a button instead of a link for the payment button
You seem to have a very firm grasp on the core fundamentals of html and css. Good work ๐
1@AhlamAb22Posted about 1 year agoYes, I forgot about this CSS since I removed the attribution and I will consider your recommendations. Thank you for your words this really motivates me to do better:)@Zy8712
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord