Design comparison
SolutionDesign
Solution retrospective
All feedback is welcome, Thank you
Community feedback
- @Pawel1894Posted almost 2 years ago
Hey ;)
Here is some feedback from me
- You are missing images
- add shadow for button, there is a lot online tools that helps you create box-shadow
- always wrap your html in main tag and frontend mentor attribution to footer tag it is good practice and makes your website easier to read for search engines
- I would recommend you to avoid setting style using tags like this
.container h1
it can provide issues with specificity in bigger projects and usually makes your classes not reusable. I would focus on creating utility classes for stuff like text color, bg color, flex, cursor pointer etc. Check out BEM methodology. With these approaches you can already make good habits to write your css and make your life easier in future bigger projects.
Overall really good solution! With photos would be almost the same.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord