Design comparison
Solution retrospective
I used a lot of Flex AGAIN but it was still quite fun to make.
Community feedback
- @mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>
or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
Marked as helpful0 - wrap everything in your body in
- @Stv-devlPosted over 2 years ago
Hi,
Nice solution. You could add a <main></main> in your html for have a proper html. If you want to center the card like in the original you can add a flexbox in this main :
Main { display: flex; justify-content: center; align-items: center; min-height: 100vh; }
you can also add light grey background at <div class="payment-section">I see you use a gap in your flexbox, I thought it was only for grid, I will try it also next time.
Good code
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord