order summary component (desktop)

Community feedback

• 

  Kawsar Ahmed Fahad•2,660

  @faha1999Posted about 2 years ago

  Hello, Edgar Briandt Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  • You might want to use semantic tags like the <footer> to wrap your code, instead of div. like

  <footer class="attribution"></footer>
  

  This would help improve accessibility.

  • add the below code to the body. It will center everything

  body {
      justify-content: center;
      align-items: center;
      display: flex;
      height: 100vh;
      flex-direction: column;
  }
  

  • remove margin: 50px auto; from the main.It's not needed anymore.

  • add : hover effect to the button

  • complete the mobile design too. Because this is a full challenge.

  • Instead of using px, use relative units like rem or em to get better performance when the information on your page needs to be resized for multiple screens and devices. REM and EM apply to all sizes, not just font-size. You can code your entire page in px and then, at the very end, use the VsCode plugin px to rem to perform the automatic conversion px to rem

  • This is my solution of this challenge live, repo

  I hope it will work. Happy coding.

  0