Hey @CinArb2 👋🏻
I have some suggestions to help you fix the accessibility issue and some other things.
- First, I suggest using
<h2>
or<p>
instead of<h3>
for Annual Plan, because headings in HTML have to increase gradually, such ash1, h2, h3….
. - Next, the music icon, should have
aria-hidden="true”
, because it's for decoration only. You can read more aboutaria-hidden
here. - To answer your question, yes, we do need to reset those two properties and not only those two. I won't go into many details about resetting CSS, but I'll leave this cool article here, which will make more sense than my brief explanation.
I hope this was helpful 👨🏻💻 other than that, you did a great job for your first project. Your code looks semantically correct, and those animations give some life to the project. Cheers 👾
Marked as helpful
@CinArb2
Posted
@kens-visuals Thank you so much for taking the time to check the exercise.
The article is really helpful. Helped me to understand a lil bit more about css resets.
And I will study aria labels, it looks important if i really want to understand accessibility.
Thank you so much, :D
@CinArb2 you're very welcome, glad to be helpful 😇