Order Summary Component - CSS3 & SASS + BEM & SMACSS

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @ASNovaes 👋🏻

  I have some feedback to help you fix the accessibility issues and some other things.

  • In your markup, <div class="card">...</div> should be <main class="card">...</main>. This will fix the accessibility issues, don't forget to generate a new repot once you fix the issues.
  • For the music icon, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here.
  • Hero image should have a display: block;, it removes the line underneath the image. If you want to know what's causing it, check out the 3rd section of this video
  • Also, I suggest adding transition: all 0.2s; to the button and the links, this will make :hover smoother.

  I hope this was helpful 👨🏻‍💻 all in all, you did a great job, nicely done. Cheers 👾

  Marked as helpful

  1
• 

  Alex Novaes•140

  @ASNovaesPosted about 3 years ago

  @kens_visuals 👋🏻

  Thank you very much for the feedback, it was very helpful. Cheers 👾

  0

  ---

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @ASNovaes no worries 👌🏻

  0