Order Summary Component Completed Challenge

Community feedback

• 

  P

  Rafael Dias•910

  @rafaeldgeoPosted 9 months ago

  hi! verakissyou17

  Great Job! I saw that your challenge is very responsive, only the fonts are not shrink. This is no problem. My suggestion for next project, you could clamp() function in the font-size.

  I hope this help,

  Marked as helpful

  1

  ---

  

  verakissyou17•420

  @verakissyou17Posted 9 months ago

  @rafaeldgeo Thanks for your suggestion! Clamp function needs a middle value and I don't know exactly witch is the best. So I must practice more with this function before use it on my projects,especially for font sizes.

  1

  

  P

  Rafael Dias•910

  @rafaeldgeoPosted 9 months ago

  @verakissyou17

  Yes! You're right! I practiced too much and still continue learning each new challenge.

  I had saw many challenges here, but few responsive as yours, In other words, you do a good job. Congratulations!

  Sorry my english

  Marked as helpful

  1

  

  verakissyou17•420

  @verakissyou17Posted 9 months ago

  @rafaeldgeo Thanks a lot for your feedback Don't worry about the English. I will practice more the clamp function. Good luck on your journey in coding!

  1
• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 10 months ago

  Hello there 👋 @verakissyou17.

  Good job on completing the challenge !

  Your project looks really good!

  I have suggestions about your code that might interest you.

  Consider adding a background-color of the body element to hsl(212, 45%, 89%). Both background-color and background-image can be use together.

  body {
    background-color: hsl(212, 45%, 89%);
  }
  

  I hope it helps!

  Other than that, great job!

  Happy coding.

  Marked as helpful

  1

  ---

  

  verakissyou17•420

  @verakissyou17Posted 10 months ago

  @Ezekiel225 The truth is I forgot to put the background-color on the body....I know both can be used together. Anyway, thanks for your feedback. It helped me realize that I have some issues on my code.

  0