Design comparison
SolutionDesign
Solution retrospective
Is there anything I could improve? Any constructive criticism is welcome!
Community feedback
- @vanzasetiaPosted over 1 year ago
Hi, Amanda P.! 👋
Here are a few ways you can do to improve this solution.
- The illustration and the music icon are decorative images. So, leave the alternative text empty.
- For your information, decorative images are images that don't add any information and serve only aesthetic purposes.
<button>element must always havetypeattribute to prevent unexpected behavior. Source: Checklist - The A11Y Project #use-the-button-element-for-buttons- Don't change the
<html>or the:rootfont size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements.- Grace Snow explains the issue clearly — Should I change the default HTML font-size to 62.5%?
- Joshua Comeau also does not recommend that approach — The Surprising Truth About Pixels and Accessibility: should I use pixels or rems?
- Remove
<div class="bg__image"></div>. Then, make the background pattern the background image of the<body>element.
I hope this helps. Happy coding! 😄
Marked as helpful2@ohkamandaPosted over 1 year agoGreat suggestions. This helps a lot, thank you! @vanzasetia
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord