Order Summary Component Challenge Using CSS Grid

Community feedback

• 

  Cody Lewis Zites•570

  @zitescodyPosted about 3 years ago

  Hello @hamzzei, below is some feedback on how to eliminate some of the accessibility issues on your report:

  1.) I recommend changing <div id="card"> to <main id="card">. This is important because it shows to the screen reader that THIS is your main content (what is inside is what you want people to see). Using baseline div elements doesn't allow for that.

  2.) I recommend changing the <div class="attribution"> to <footer class="attribution">. Again, this shows the screen what the content contained within the element is.

  Overall, wonderfully done. I have attached an article recommended by Frontend Mentor that will help you optimize your frontend journey to be more accessible!

  https://dequeuniversity.com/rules/axe/4.3/region?application=axeAPI

  0

  ---

  

  hamzzei•60

  @jameshamlingPosted about 3 years ago

  @zitescody Thanks for the feedback! It is very appreciated. I don't know why I forgot to split this up into main and footer but I will remember this for the next project!

  0