Skip to content
Submitted 9 months ago

Order summary component v2

Osei-Bonsu Isaac•50
@io-oseinana
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Olaniyi Ezekiel•7,580
    @Ezekiel225Posted 9 months ago

    Hello there 👋 @io-oseinana.

    Good job on completing the challenge !

    Your project looks really good!

    I have a suggestion about your code that might interest you.

    There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

    Consider adding a min-height of 100vh to the body element so as to centralize your project.

    body { 
  min-height: 100vh;
  align-items: center;
  display: flex;
  justify-content: center;
}

    I hope this suggestion is useful for future projects.

    Other than that, great job!

    Happy coding.

    Marked as helpful
    1
    Osei-Bonsu Isaac•50
    @io-oseinanaPosted 9 months ago

    Thank you for your suggestion @Ezekiel225 I'll make the changes soon

    0
  • Øystein Håberg•10,390
    @Islandstone89Posted 9 months ago

    HTML:

    • The image and icon are decorative, so the alt text must be empty:alt="".

    • "Cancel Order" would likely trigger an action, so it should be a <button>.

    • .attribution should be a <footer>, and its text must be wrapped in a <p>. It must also be moved outside of the <main>.

    CSS:

    • Performance-wise, it's better to link fonts in the <head> of the HTML than using @import.

    • It's good practice to include a CSS Reset at the top.

    • Move the properties on main over to body. Change height to min-height, and add gap: 2rem to create space between the main and the footer.

    • Remove all widths and heights.

    • Remove margin on image.

    • Remove justify-content: center on the card.

    • Add some padding on .order__card__content.

    • Media queries should be in rem.

    • Change font size on attribution from px to rem.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord