Order summary component - card project using CSS Flexbox

Community feedback

• 

  Thomas Hertog•825

  @thomashertogPosted over 1 year ago

  almost looking exactly like the design, so that's very good

  few improvements can be made though

  HTML/accessibility

  • There's no landmark being used. Yes you used a <section> however, that doesn't correspond with a landmark role.
  • You have a lot of <div> wrapper elements which are (mostly) unnecessary

  CSS

  • there's a breakpoint for the smaller screen sizes but that one also has a minimum
  • you'll be better off coding things mobile-first instead of desktop-first (which i feel you're doing now)
  • a lot of px-based values, which are totally unresponsive
  • you should use min-height as opposed to height so elements get room to expand when needed instead of causing issues with overflow

  0