Design comparison
SolutionDesign
Solution retrospective
My second submission on Frontendmentor. Any feedbacks are greatly appreciated! 🙏🏻
Community feedback
- @NomiDomiPosted almost 3 years ago
Hey @cornthecob,
Congrats on completing your second challenge! :)
Here are some tips on my side:
- avoid putting heights on your tags, classes etc. Let the height be adjusted automatically by the content inside
- for a smooth transition from desktop to mobile avoid using pixels for most things. Here is a great tutorial that talks about the different types of units that you can use
- use CSS variables for your font family, sizes, margins and paddings too, not just for your colors
- give more generic names to your color custom properties. Instead of
--VeryPaleBlue
use--primary-clr
. In case you decide to change your colors, your --VeryPaleBlue might have to be green or red and then your variable name will be very confusing - for easy access to your code consider putting your html and css files in a folder named src. Src stands for source and it is usually used to easily distinguish between the code and additional helper files. Also add all the images you use in your code in a folder named images or assets inside your src folder
Hope this helps! Keep on coding! :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord