Design comparison
SolutionDesign
Solution retrospective
I'd love to hear your thoughts and suggestions on how I can improve my code.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, David! š
Good effort on this challenge! š It's great that you are using the landmark elements correctly! š
Some suggestions.
- The
b
tag has been deprecated, instead I would recommend usingstrong
instead. Note that not all bold text needs to be wrapped withstrong
. - Always use a meaningful element to wrap text content. I notice that you wrap the
$59.99/year
with aspan
, so I would suggest using thep
tag instead. - For any decorative images, each
img
tag should have emptyalt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only. - Also, alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
I hope this information is useful! Happy coding! š
Marked as helpful1@navidabdiPosted over 2 years ago@vanzasetia Thank you Vanza, I appreciate your effort to write this helpful comment. I'll decently consider this factors the next time :)
0@vanzasetiaPosted over 2 years ago@navidabdi No problem! Glad to help you! š
1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord