Order Summary Component build with react and react-bootstrap

Community feedback

• 

  Jurjen•90

  @snhmibbyPosted about 3 years ago

  Hello! Some general observations

  • you can add node_modules in .gitignore and only leave json config files. The node_modules directory is so huge github won't even display all of it.
  • If you go all the way to make a component, don't hardcode the order-values but have them passed in as parameters to have practice in building a reusable web component.
  • you have a .scss file, but your code is mostly plain .css. Sass is great because the hierarchy of your styles can mimick the hierarchy of your HTML, which greatly improves read- and understandability.

  Marked as helpful

  0

  ---

  

  Saima Sayed•50

  @Saima422Posted about 3 years ago

  @snhmibby Thanks for the Awesome Feedback. I will make sure to implement these practices from now on.

  1