@pikapikamart
Posted
Hey, awesome work on this one. Layout in genera looks really good.
You already got some feedbacks from others which is great, just going to add some as well:
- You don't have to use
position: absolute
on this one. Try inspecting your layout, hover on thebody
tag, you will notice that it doesn't have anyheight
this is because thecard
component is out of the flow. Instead, remove theposition: absolute
and on thebody
tag, use :
body {
align-items: center; # centers vertically
display: flex;
justify-content: center; # centers horizontally
min-height: 100vh; # takes full viewport
}
Then just remove the position, left, top, transform
property on the card
selector.
- Always have a
main
element on a webpage. For this one, thecard
selector could use themain
instead ofdiv
. - Always have an
h1
element on a webpage. - The
proceed to payment
could usea
tag instead ofbutton
, since this is not aform
andbutton
does not do anything in here.
Aside from those, really great job on this one.
Marked as helpful
@Elab4d1
Posted
@pikamart thank you again for your feedback, those are really good advices and suggestions, I'll try to use them. Thank you
@Elab4d1
Posted
@pikamart I fixed the accessibility issues thanks to your suggestions, thank you :)