Order Summary Component - BEM, CSS Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  2

  ---

  

  Chris•40

  @diru0Posted over 1 year ago

  @0xAbdulKhalid Thank you Abdul. I changed body height to min-height as you suggested. 👋🏻

  1
• 

  Suleman•750

  @legion40216Posted over 1 year ago

  maybe you can improve on ur semantic html of main tag instead of div, But kudos bro the HTML and CSS is very clean and organized refrain from using height property.

  Marked as helpful

  1

  ---

  

  Chris•40

  @diru0Posted over 1 year ago

  @legion40216 Thanks Suleman, I changed .card tag to main as you suggested. 🦾

  1