Travolgi 🍕• 31,420
@denielden
Posted
Hi Nithin, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add descriptive text in the
alt
attribute of the image - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - centering a
div
withabsolute
positioning is now deprecated, it uses modern css likeflexbox or grid
- try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - try to add a little
transition
on the element with hover effect
Overall you did well 😉
Hope this help and happy coding!
Marked as helpful
1
Nithin• 120
@Nithin-droid
Posted
@denielden Thanks for the suggestions I will implement them.
1