Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace<div class="box-card">with the main tag, <h2> with <h1>, <h3> with <p> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/
Change the background size of the body to
background-size: contain;
To center .box-card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body. Instead of giving .box-card position: absolute and its properties.
Give .box-card a fixed max-width value and height of auto and remove overflow: hidden; eg.
.box-card{ max-width: 420px; hieght: auto;}
Give the padding of .text-content a fixed value instead of a percentage value. .payments has a wrong background-color.
You forgot to add the hover effect to the design.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful
Well done for completing this challenge. HAPPY CODING
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord