Design comparison
SolutionDesign
Community feedback
- @anoshaahmedPosted almost 3 years ago
Hey good job on this challenge! Your report above shows a few issues. You can fix them by
- wrap everything in your body in
<main>
... OR use semantic tags! .... you can also giverole=""
to the direct children of your<body>
but that's a little frowned upon... Read more here - have at least one
<h1>
in your code - add
alt=""
to your<img>
tags
Hope this helps :)
Marked as helpful0 - wrap everything in your body in
- @RioCantrePosted almost 3 years ago
Hello there! Good job making it this far. Your design is great and looking at your solution I think you should considered the following as well...
- Inside the rule set
body, html
adjust the height into 50% that isheight:50%;
and add the background-color as well. - Add a hover state with the
.button1
property - Add
cursor: pointer
for both.button1
and.button2
- On every image used , include an
alt
to specify the image - Wrap the
container
withmain
tag andattribution
withfooter
tag
Overall you did well, and Keep going!
Marked as helpful0@RioCantrePosted almost 3 years ago@olabisi09 No worries. I would also appreciate if you mark it as helpful. Cheers!
0 - Inside the rule set
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord