Design comparison
SolutionDesign
Community feedback
- @Akhil-NagpalPosted over 1 year ago
Hello Tiksha! 👋 Congratulations on completing your first challenge! 🎉
I have some suggestions regarding your code.
- Always start your code by adding
<main>
tag after<body>
tag. And use semantic HTML elements like<section>, <footer>, <nav>
to avoid accessibility errors. - You didn't add an
alt="girl-listening-to-music"
attribute in the<img>
element. Every image must contain an alternative text. - You used a backward slash in the
src="images\icon-music.svg"
. Use a forward slash. - Try to use external CSS files instead of using Internal CSS. Internal CSS is not a bad practice, but this might be problematic with multiple CSS files. If you want to use internal CSS to add style to an HTML file, you should learn a CSS framework like Tailwind or Bootstrap.
I hope these suggestions will help you improve 😊
Otherwise! You did a great job! 👏 Happy Coding!
0 - Always start your code by adding
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord