Order summary card solution

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  wrap <div class="attribution"> in the footer tag to fix the accessibility issue.

  There is no need to give the body a max-width value. Add a background-color of pale-blue to the body and change the value of the background-size to contain.

  To center the main on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Gabriela•180

  @PaulaR-05Posted almost 2 years ago

  @Hassiai Perfect Hassia! Thank you so much!

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The article and section element is being used incorrectly ⚠️ and not needed for this challenge .

  • Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset

  • ⚠️ In the media-query you only need to include code that is being changed; no need to repeat code that is not changing.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0

  ---

  

  Gabriela•180

  @PaulaR-05Posted almost 2 years ago

  @vcarames Heeeey! Thank you so much for helping me out! Could I ask one more thing? *[The article and section element is being used incorrectly ⚠️ and not needed for this challenge ] Should I use "div" instead of article or section? I thought it would be better to use them.

  thanks, all your comments have always helped me a lot!:)

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @PaulaR-05

  Glad I could help!

  Yup! That would be the best choice.

  In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site).

  While the section is to define groups that have related content in a full site; Think book chapters.

  Hope this clears things up.

  Marked as helpful

  1