Order summary component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for main element instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  BACKGROUND iMAGE 📸:

  • Looks like the background svg and color has not been set, So let me explain How you can easily apply the background color with the svg they provided.

  ---

  • Add the following style rule to your css, and then experience the changes

  body {
      background: url(./images/pattern-background-desktop.svg), #E1E9Ff;
      background-repeat: no-repeat, no-repeat;
  }
  

  ---

  • Tip, Don't forget to generate a new screenshot after editing the css file

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Abdelkarim Douadjia•60

  @AbdelkarimDouadjiaPosted over 1 year ago

  @0xAbdulKhalid Thank you so much for the helpful recommendations! I appreciate the explanation of why using min-height instead of height is a better practice for the main element. I will make sure to implement this change in my future projects.

  Also, thank you for providing a solution for setting the background image and color. I will add the suggested CSS rule to my code and generate a new screenshot to see the changes.

  Your feedback and suggestions have been extremely valuable, and I am grateful for your help. Thank you again for taking the time to review my code and provide these recommendations. Happy coding to you too!

  0
• 

  Victória Nogueira Marques•390

  @victoriamnxPosted over 1 year ago

  You can use the z-index function to place the image in the background, for example: z-index: 0; (in the background image) and z-index: 1; in the other components.

  It's just a tip, I hope it helps, the result was great and pretty :).

  Marked as helpful

  0

  ---

  

  Abdelkarim Douadjia•60

  @AbdelkarimDouadjiaPosted over 1 year ago

  @victoriamnx Thank you for the tip on using the z-index function to place an image in the background! I appreciate your suggestion and will keep it in mind when working on future projects. It's always helpful to learn new techniques and improve my skills as a developer. Thank you again!

  0